[AutoParallel] Converter #40434
Merged
[AutoParallel] Converter #40434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Thanks for your contribution! |
JZ-LIANG reviewed Mar 11, 2022
| "but got '{}'.".format(str(type(cur_strategy)))) | ||
| self._cur_strategy = cur_strategy | ||
| | ||
| def convert(self, strict=True): |
Contributor
There was a problem hiding this comment.
explain meaning of "strict" argument in doc
JZ-LIANG reviewed Mar 11, 2022
| .. code-block:: python | ||
| | ||
| import numpy as np | ||
| complete_param = np.arange(4).reshape([2, 2]) |
Contributor
There was a problem hiding this comment.
complete_param --> complete_params
JZ-LIANG reviewed Mar 11, 2022
| param_not_in_ckpt.append(param_name) | ||
| continue | ||
| | ||
| param_list = self._params_dict[param_name] |
Contributor
There was a problem hiding this comment.
"param_xxx" --> "tesnor_xxx" a more proper and meaningful naming
JZ-LIANG reviewed Mar 11, 2022
| partition_index, complete_shape) | ||
| | ||
| assert len(partition_param_list) == 1 or not partition_param_list, \ | ||
| "Fail to merge parameter" |
Contributor
There was a problem hiding this comment.
also throw out the information of failed tensor, like name, pre_dist_attr, target_dist_attr
added 2 commits March 11, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe