Skip to content

Conversation

@jim19930609
Copy link
Contributor

@jim19930609 jim19930609 commented Mar 7, 2022

PR types

New features

PR changes

Others

Describe

Added more signposts to improve the performance profiling for each runtime dygraph module. As a result, performance of the following dygraph modules will be profiled after this patch:

Forward Pass:

  1. Python-C entrance
  2. TraceOp entrance / Dygraph Functions entrance
  3. Kernel Compute
  4. CreateGradNode

Backward Pass:

  1. BasicEngine::Execute() / Runbackward()
  2. Start of each loop when looping through all the OpBases
  3. Kernel Compute
@paddle-bot-old
Copy link

paddle-bot-old bot commented Mar 7, 2022

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@jim19930609 jim19930609 changed the title Added more signposts to dygraph profiling Added more profile signposts to dygraph profiling Mar 7, 2022
@jim19930609 jim19930609 changed the title Added more profile signposts to dygraph profiling Added more profile signposts to dygraph Mar 7, 2022
Copy link
Contributor

@pangyoki pangyoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有加完打点后的timeline的效果图吗?

Copy link
Contributor

@pangyoki pangyoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jim19930609 jim19930609 merged commit 36db75b into PaddlePaddle:develop Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants