[phi] move viterbi_decode to phi #40186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Thanks for your contribution! |
…to move_viterbi
chenwhql reviewed Mar 8, 2022
paddle/phi/infermeta/multiary.cc Outdated
| out->set_dtype(x.dtype()); | ||
| } | ||
| | ||
| void ViterbiDecodeInferMeta(const MetaTensor& input, |
Contributor
There was a problem hiding this comment.
这里有三个tensor参数？是不是应该属于ternary.h/cc
| namespace funcs { | ||
| | ||
| template <typename Context, typename T> | ||
| inline void TransCompute(const int dim, |
Contributor
There was a problem hiding this comment.
这个有没有可能直接用transpose_kernel.h中的Transpose替代，避免重复封装
| } | ||
| } | ||
| | ||
| class TensorBuffer { |
Contributor
There was a problem hiding this comment.
这种在内部封装类似Tensor的结构是应该避免的，我们后续优化下这个算子
| #include <string> | ||
| #include <vector> | ||
| | ||
| #include "paddle/fluid/operators/elementwise/elementwise_op_function.h" |
Contributor Author
There was a problem hiding this comment.
这里LaunchElementwiseCudaKernel需要用到
YuanRisheng reviewed Mar 8, 2022
Comment on lines 17 to 19
| #ifdef PADDLE_WITH_MKLML | ||
| #include <omp.h> | ||
| #endif |
Contributor
There was a problem hiding this comment.
我看到funcs/viterbi_decode_functor.h下也用到了这个头文件的内容，这个头文件引用是否放在那个文件里更合适一点？
zyfncg reviewed Mar 8, 2022
Comment on lines 172 to 174
| DenseTensor int_buffer; | ||
| int_buffer.Resize(phi::make_ddim({buffer_size})); | ||
| dev_ctx.template Alloc<int64_t>(&int_buffer); |
Contributor
There was a problem hiding this comment.
这种写法可以试试使用 int_buffer = Empty<int64_t>(dev_ctx, {buffer_size})；, 写起来会简单一些
Comment on lines 180 to 182
| DenseTensor float_buffer; | ||
| float_buffer.Resize(phi::make_ddim({buffer_size})); | ||
| dev_ctx.template Alloc<T>(&float_buffer); |
zyfncg approved these changes Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
OPs
Describe
move viterbi_decode to phi