Move dropout to phi #40148
Merged
Move dropout to phi #40148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Thanks for your contribution! |
… move_dropout_to_phi
… move_dropout_to_phi
chenwhql reviewed Mar 8, 2022
| namespace phi { | ||
| | ||
| template <typename T, typename Context> | ||
| void DropoutGradRawKernel(const Context& dev_ctx, |
| template <typename T, typename Context> | ||
| void DropoutRawKernel(const Context& dev_ctx, | ||
| const DenseTensor& x, | ||
| paddle::optional<const DenseTensor&> seed_tensor, |
Contributor
There was a problem hiding this comment.
seed tensor的下面的seed应该用Scalar统一表示？而不是写两个参数？
| bool is_test, | ||
| const std::string& mode, | ||
| DenseTensor* x_grad) { | ||
| x_grad->mutable_data<T>(dev_ctx.GetPlace()); |
| bool fix_seed, | ||
| DenseTensor* out, | ||
| DenseTensor* mask) { | ||
| out->mutable_data<T>(dev_ctx.GetPlace()); |
| KernelSignature DropoutOpArgumentMapping(const ArgumentMappingContext& ctx) { | ||
| return KernelSignature( | ||
| "dropout", | ||
| {"X", "Seed"}, |
zyfncg reviewed Mar 9, 2022
| DenseTensor* x_grad) { | ||
| auto* grad_x = x_grad; | ||
| auto* grad_y = &out_grad; | ||
| grad_x->mutable_data<T>(dev_ctx.GetPlace()); |
| | ||
| #pragma once | ||
| | ||
| #include "paddle/phi/common/scalar.h" |
chenwhql approved these changes Mar 9, 2022
Contributor
chenwhql left a comment
chenwhql left a comment There was a problem hiding this comment.
LGTM overall，细节问题后续PR再完善一下
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR types
Breaking changes
PR changes
OPs
Describe
move dropout to phi