Sparse Conv3d gpu backward #40143
Merged
Sparse Conv3d gpu backward #40143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added 17 commits February 17, 2022 09:24
| Thanks for your contribution! |
added 12 commits March 4, 2022 01:44
… conv3d_gpu_backward
… conv3d_gpu_backward
… into conv3d_gpu_backward
… conv3d_gpu_backward
… conv3d_gpu_backward
… conv3d_gpu_backward
xingfeng01 reviewed Mar 9, 2022
| } | ||
| } | ||
| | ||
| // TODO(zhangkaihuo): After the GatherCUDAKernel is migrated to phi, replace |
Contributor Author
There was a problem hiding this comment.
目前换了个位置，后面会把这个方法替换成已有的gatter kernel.
xingfeng01 approved these changes Mar 9, 2022
| T* in_features_ptr = in_features.data<T>(); | ||
| T* d_x_features_ptr = d_x_features.data<T>(); | ||
| T* out_grad_features_ptr = out_grad_features.data<T>(); | ||
| kernel_grad->Resize(kernel_dims); |
Contributor
There was a problem hiding this comment.
这里不能使用ResizeAndAlloc吗？
| | ||
| // 4. scatter | ||
| x_grad->Resize(x.non_zero_elements().dims()); | ||
| dev_ctx.Alloc(x_grad, x_grad->dtype(), sizeof(T) * x_grad->numel()); |
| &unique_key, | ||
| &unique_value); | ||
| | ||
| config = phi::backends::gpu::GetGpuLaunchConfig1D( |
Contributor
There was a problem hiding this comment.
这个上面不是已经计算过了吗？为什么不直接使用
| DenseTensor out_index = phi::Empty<int, Context>(dev_ctx); | ||
| DenseTensor unique_key = phi::Empty<int, Context>(dev_ctx); | ||
| DenseTensor unique_value = phi::Empty<int, Context>(dev_ctx); | ||
| DenseTensor out_index = phi::Empty( |
Contributor
There was a problem hiding this comment.
可以创建一个meta 然后传到这三个Empty中
AnnaTrainingG approved these changes Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Describe