[PHI] Move segment_pool to phi. #40099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Thanks for your contribution! |
MingMingShangTian previously approved these changes Mar 7, 2022
zyfncg reviewed Mar 7, 2022
| #include "paddle/phi/core/dense_tensor.h" | ||
| #include "paddle/phi/core/kernel_registry.h" | ||
| #include "paddle/phi/kernels/impl/segment_pool_grad_kernel_impl.h" | ||
| #include "paddle/phi/kernels/segment_pool_grad_kernel.h" |
Contributor
There was a problem hiding this comment.
segment_pool_grad_kernel.h建议放在开头
| #include "paddle/phi/core/dense_tensor.h" | ||
| #include "paddle/phi/core/kernel_registry.h" | ||
| #include "paddle/phi/kernels/impl/segment_pool_kernel_impl.h" | ||
| #include "paddle/phi/kernels/segment_pool_kernel.h" |
| phi::funcs::SetConstant<Context, T> set_zero; | ||
| set_zero(dev_ctx, x_grad, static_cast<T>(0)); | ||
| | ||
| auto index_type = paddle::framework::TransToProtoVarType(segment_ids.type()); |
Contributor
There was a problem hiding this comment.
这里不需要转成proto::VarType了，直接用DataType类型做判断就行
| | ||
| namespace phi { | ||
| | ||
| using Tensor = DenseTensor; |
| length.Resize(phi::make_ddim({1})); | ||
| IndexT* length_data = dev_ctx.template HostAlloc<IndexT>(&length); | ||
| | ||
| // IndexT* length_data = length.data<IndexT>(); |
| const std::string& pooltype, | ||
| DenseTensor* out, | ||
| DenseTensor* summed_ids) { | ||
| auto index_type = paddle::framework::TransToProtoVarType(segment_ids.dtype()); |
Comment on lines 19 to 23
| KernelSignature SegmentPoolOpArgumentMapping( | ||
| const ArgumentMappingContext& ctx) { | ||
| return KernelSignature( | ||
| "segment_pool", {"X", "SegmentIds"}, {"pooltype"}, {"Out", "SummedIds"}); | ||
| } |
Contributor
There was a problem hiding this comment.
这里前向ArgumentMapping感觉可以不写，用默认的应该也能work
zyfncg approved these changes Mar 9, 2022
Avin0323 approved these changes Mar 10, 2022
Contributor
Avin0323 left a comment
Avin0323 left a comment There was a problem hiding this comment.
LGTM for unity_build_rule.cmake
MingMingShangTian approved these changes Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
OPs
Describe
Move segment_pool to phi.