[Phi] move the graph_send_recv op to the phi #40092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| ✅ This PR's description meets the template requirements! |
| Thanks for your contribution! |
| }; | ||
| | ||
| template <typename T, typename IndexT, typename Functor> | ||
| void elementwise_inner_operation(const DenseTensor& src, |
Contributor
There was a problem hiding this comment.
这个函数命名不符合代码规范，驼峰命名
Contributor Author
There was a problem hiding this comment.
这个函数命名不符合代码规范，驼峰命名
已更改
| namespace phi { | ||
| | ||
| template <typename T, typename IndexT, typename Functor> | ||
| void graph_send_recv_cpu_for_loop_grad(const int& input_size, |
YuanRisheng reviewed Mar 4, 2022
Contributor
YuanRisheng left a comment
YuanRisheng left a comment There was a problem hiding this comment.
这个op补充了benchmark脚本了吗
| #include <algorithm> | ||
| #include <vector> | ||
| | ||
| #include "paddle/fluid/operators/eigen/eigen_function.h" |
zyfncg reviewed Mar 4, 2022
Comment on lines +15 to +16
| #include "paddle/phi/kernels/gpu/graph_send_recv_funcs.h" | ||
| #include "paddle/phi/kernels/graph_send_recv_kernel.h" |
Contributor Author
op benchmark已增加 |
zyfncg approved these changes Mar 8, 2022
Comment on lines +15 to +16
| #include "paddle/phi/kernels/gpu/graph_send_recv_funcs.h" | ||
| #include "paddle/phi/kernels/graph_send_recv_grad_kernel.h" |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
OPs
Describe
move the graph_send_recv op to the phi