Skip to content

Conversation

@From00
Copy link
Contributor

@From00 From00 commented Mar 1, 2022

PR types

Function optimization

PR changes

OPs

Describe

  1. Move BroadcastTensors OP to phi
  2. Change the template parameter of Real/ImagKernel from DeviceContext to Context in complex_kernel.h
@paddle-bot-old
Copy link

paddle-bot-old bot commented Mar 1, 2022

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Mar 1, 2022

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@zyfncg zyfncg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

相关的op-benchmark是否已经添加?

switch (reshape_size) {
#define LOWER_SWITCH_REDUCE_DIMS \
default: { \
PADDLE_THROW(paddle::platform::errors::InvalidArgument( \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phi::error

Comment on lines 32 to 38
void BilinearTensorProductInferMeta(const MetaTensor& x,
const MetaTensor& y,
const MetaTensor& weight,
paddle::optional<const MetaTensor&> bias,
MetaTensor* out,
MetaConfig config = MetaConfig());

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

规则更新了一下,这个InferMeta函数按照最新规范是放在multiary.h文件

if (target_dim_size != 1 && dim_size != 1 &&
target_dim_size != dim_size) {
PADDLE_THROW(paddle::platform::errors::InvalidArgument(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phi::errors

@From00
Copy link
Contributor Author

From00 commented Mar 2, 2022

相关的op-benchmark是否已经添加?

@zyfncg
benchmark脚本已合入:PaddlePaddle/benchmark#1322
其它几个小comments都已修改过来

Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@From00 From00 merged commit 2a5590a into PaddlePaddle:develop Mar 2, 2022
@From00 From00 deleted the move-broadcast-tensor-op-to-phi branch March 11, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants