Move sgd to phi #40045
Merged
Move sgd to phi #40045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
… move_sgd_to_phi
… move_sgd_to_phi
… move_sgd_to_phi
| Thanks for your contribution! |
chenwhql approved these changes Mar 2, 2022
| multi_precision ? master_param->data<MPDType>() : nullptr; | ||
| MPDType* master_out_data = | ||
| multi_precision | ||
| ? master_param_out->mutable_data<MPDType>(dev_ctx.GetPlace()) |
| grad.data<T>(), | ||
| learning_rate.data<T>(), | ||
| param.numel(), | ||
| param_out->mutable_data<T>(dev_ctx.GetPlace()), |
| multi_precision ? master_param->data<MPDType>() : nullptr; | ||
| MPDType* master_out_data = | ||
| multi_precision | ||
| ? master_param_out->mutable_data<MPDType>(dev_ctx.GetPlace()) |
| } | ||
| | ||
| template <typename T> | ||
| void sgd_dense_param_sparse_grad_impl(const DenseTensor& param, |
Contributor
There was a problem hiding this comment.
按照编码规范，这些内部函数应该都是驼峰式命名，可能原来的同学写得不规范，可以顺便改下
zyfncg approved these changes Mar 2, 2022
Contributor
zyfncg left a comment
zyfncg left a comment There was a problem hiding this comment.
Optimizer相关的SelectedRows kernel是否要按照目前的规则放在selected_rows目录下？
Comment on lines +77 to +82
| // do check here | ||
| // if (multi_precision) { | ||
| // bool has_master = | ||
| // ctx.HasInput("MasterParam") && ctx.HasOutput("MasterParamOut"); | ||
| | ||
| // } |
Comment on lines +114 to +119
| // do some check here | ||
| // if (multi_precision) { | ||
| // bool has_master = | ||
| // ctx.HasInput("MasterParam") && ctx.HasOutput("MasterParamOut"); | ||
| | ||
| // } |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR types
Breaking changes
PR changes
OPs
Describe
move sgd to phi