Skip to content

Conversation

@2742195759
Copy link
Contributor

PR types

Others

PR changes

Others

Describe

[phi] transfer pad kernel into phi and pass the test_pad_op

@paddle-bot-old
Copy link

paddle-bot-old bot commented Mar 1, 2022

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@YuanRisheng YuanRisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pad有添加benchmark的脚本吗

int MajorType = Eigen::RowMajor,
typename IndexType = Eigen::DenseIndex>
using EigenTensor = framework::EigenTensor<T, D, MajorType, IndexType>;
using EigenTensor = paddle::framework::EigenTensor<T, D, MajorType, IndexType>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eigen已经迁至phi下,具体可查看phi/kernels/funcs/eigen/common.h

Comment on lines 18 to 19
#include "paddle/fluid/framework/eigen.h"
#include "paddle/fluid/operators/eigen/eigen_function.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看一下能否替换成phi下的eigen

@Aurelius84 Aurelius84 merged commit 9f74b84 into PaddlePaddle:develop Mar 3, 2022
@2742195759 2742195759 deleted the pad branch March 16, 2022 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants