[phi] move diag_v2 to phi #39914
Merged
[phi] move diag_v2 to phi #39914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Thanks for your contribution! |
YuanRisheng approved these changes Feb 25, 2022
zyfncg approved these changes Feb 25, 2022
| | ||
| namespace phi { | ||
| | ||
| KernelSignature DiagOpArgumentMapping(const ArgumentMappingContext& ctx) { |
Contributor
There was a problem hiding this comment.
这里的Mapping映射感觉可以不写，使用默认op_proto映射应该也work，如果删掉也work的话可以后面再提个PR完善下
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
OPs
Describe
1.move diag_v2 to phi
2.修复 #39868 comments