Modified sigmoid by the elementwise interface. #39898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
huangxu96 changed the title 
| template <typename T> | ||
| struct DivFunctor { | ||
| const T *norm_; | ||
| HOSTDEVICE inline DivFunctor(const T *norm) : norm_(norm) {} |
Contributor
There was a problem hiding this comment.
这里也可以直接使用double存储div = 1/norm 然后在下面使用loss = loss * div
| const std::vector<int> reduce_dim = {1}; | ||
| TensorReduceImpl<T, T, kps::AddFunctor, NonzeroFunctor<T>>( | ||
| context.cuda_device_context(), *counts_tensor, norm_tensor, | ||
| NonzeroFunctor<T>(), reduce_dim, dev_ctx.stream()); |
Contributor
There was a problem hiding this comment.
1.这里为什么使用NonzeroFunctor ? NonzeroFunctor有类型转换， 使用identityFunctor比较合适
Liu-xiandong approved these changes Mar 3, 2022
xingfeng01 approved these changes Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR types
Performance optimization
PR changes
OPs
Describe
Use elementwise interface to optimize sigmoid