Supported Complex2Real Conversion for Eager Dygraph #39878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
… support_complex
JiabinYang reviewed Feb 28, 2022
Contributor
JiabinYang left a comment
JiabinYang left a comment There was a problem hiding this comment.
try to test more tests in test_imperative_auto_prune.py
jim19930609 force-pushed the support_complex branch from cc3ca4d to 4855da1 Compare jim19930609 force-pushed the support_complex branch from 185f1c8 to b106ae3 Compare jim19930609 force-pushed the support_complex branch from b106ae3 to 1ded93a Compare jim19930609 force-pushed the support_complex branch from 3cb3c8a to 9942837 Compare jim19930609 force-pushed the support_complex branch from 0dc693f to 489e146 Compare 
| Sorry to inform you that 489e146's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
JiabinYang reviewed Mar 17, 2022
| | ||
| // Set Grad out rank as same as fwd input and set stop gradient to bwd | ||
| scale_node->SetGradOutMeta(p_autograd_in, /*slot id*/ 0); | ||
| scale_node->SetGradOutMeta(x, /*slot id*/ 0); |
Contributor
There was a problem hiding this comment.
may be we should remove this in later PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe
Supported Complex2Real Conversion for Eager Dygraph