Skip to content

fix batch_norm parameter share #3982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 9, 2017
Merged

fix batch_norm parameter share #3982

merged 3 commits into from
Sep 9, 2017

Conversation

@chengduoZH
Copy link
Contributor

@chengduoZH chengduoZH commented Sep 9, 2017 •
edited
Loading

fix #3984
qingqing01
qingqing01 reviewed Sep 9, 2017
View reviewed changes
python/paddle/trainer_config_helpers/layers.py Outdated
bias_attr=None,
param_attr=None,
layer_attr=None,
mean_var_names=None,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put the new argument as the last one.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done
python/paddle/trainer_config_helpers/layers.py Outdated
:param layer_attr: Extra Layer Attribute.
:type layer_attr: ExtraLayerAttribute
:param mean_var_names: [mean name, variance name]
:type mean_var_names: string list
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put the new argument as the last one.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done
python/paddle/trainer/config_parser.py Outdated
inputs,
bias=True,
use_global_stats=True,
mean_var_names=None,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

# ... moving_average_fraction=0.9, batch_norm_type=None, mean_var_names=None, **xargs):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done
@qingqing01 qingqing01 merged commit a225bfa into develop Sep 9, 2017
@luotao1 luotao1 deleted the fix_batch_norm_parameter_share branch September 21, 2017 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@chengduoZH @qingqing01