Move real and imag op to phi #39777
Merged
Move real and imag op to phi #39777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| ✅ This PR's description meets the template requirements! |
| Thanks for your contribution! |
zyfncg reviewed Feb 21, 2022
Contributor
zyfncg left a comment
zyfncg left a comment There was a problem hiding this comment.
real和imag这两个kernel可以都放到complex_kernel文件里，能减少一些文件数量
| | ||
| #include "paddle/phi/common/complex.h" | ||
| #include "paddle/phi/core/kernel_registry.h" | ||
| #include "paddle/phi/kernels/imag_kernel.h" |
| #include "paddle/phi/common/complex.h" | ||
| #include "paddle/phi/core/kernel_registry.h" | ||
| #include "paddle/phi/kernels/impl/real_grad_kernel_impl.h" | ||
| #include "paddle/phi/kernels/real_grad_kernel.h" |
| #include "paddle/phi/common/complex.h" | ||
| #include "paddle/phi/core/kernel_registry.h" | ||
| #include "paddle/phi/kernels/impl/real_kernel_impl.h" | ||
| #include "paddle/phi/kernels/real_kernel.h" |
| | ||
| #include "paddle/fluid/platform/for_range.h" | ||
| #include "paddle/phi/kernels/funcs/complex_functors.h" | ||
| #include "paddle/phi/kernels/imag_grad_kernel.h" |
Contributor
There was a problem hiding this comment.
这里应该不需要引imag_grad_kernel.h这个头文件了
| | ||
| #include "paddle/fluid/platform/for_range.h" | ||
| #include "paddle/phi/kernels/funcs/complex_functors.h" | ||
| #include "paddle/phi/kernels/imag_kernel.h" |
| | ||
| namespace phi { | ||
| | ||
| template <typename T, typename DeviceContext> |
Contributor
There was a problem hiding this comment.
按照目前规范，Kernel模板参数DeviceContext先统一为Context
| auto numel = x.numel(); | ||
| auto* x_data = x.data<T>(); | ||
| auto* out_data = dev_ctx.template Alloc<phi::funcs::Real<T>>( | ||
| out, static_cast<size_t>(numel * sizeof(phi::funcs::Real<T>))); |
Contributor
There was a problem hiding this comment.
这里需要明确指定out_data的内存大小吗？如果使用默认值分配会有问题吗？
Contributor Author
done |
… move-real-and-imag-op-to-phi
zyfncg approved these changes Feb 22, 2022
| @@ -0,0 +1,31 @@ | |||
| /* Copyright (c) 2021 PaddlePaddle Authors. All Rights Reserved. | |||
| return x; | ||
| } | ||
| | ||
| template <typename T, typename DeviceContext> |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
OPs
Describe
Move real and imag op to phi