Skip to content

Conversation

@zhiqiu
Copy link
Contributor

@zhiqiu zhiqiu commented Feb 16, 2022

PR types

Function optimization

PR changes

Others

Describe

[new-exec] To make code clean, refactor code of interpretercore gc

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@zhiqiu zhiqiu requested a review from From00 February 16, 2022 08:51
@zhiqiu zhiqiu changed the title [new-exec] relocate code of interpretercore gc [new-exec] refactor code of interpretercore gc Feb 16, 2022
Variable* var, platform::DeviceEvent* event,
const platform::DeviceContext* ctx) {
PADDLE_THROW(platform::errors::Unimplemented(
"Not implemented for InterpreterCoreEventGarbageCollector."));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"InterpreterCoreEventGarbageCollector" -> "InterpreterCoreFastGarbageCollector"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

@From00 From00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhiqiu zhiqiu merged commit c313542 into PaddlePaddle:develop Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants