Skip to content

Conversation

@chenwhql
Copy link
Contributor

@chenwhql chenwhql commented Feb 15, 2022

PR types

Others

PR changes

Others

Describe

[PTen] Clean useless header in pten core

pten core目录下头文件中对fluid头文件的include需要移除,自定义kernel工作有依赖,本PR移除对fluid/framework/data_type.h的依赖

顺便做了一些代码整理的工作

  • 对dtype的命名空间进行必要的替换(移除data_type.h之后编译会失败)
  • 移除重复实现transpose.*,math_funciton中有完全一样的代码
  • pten中单测统一移到tests目录
@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

XieYunshen
XieYunshen previously approved these changes Feb 16, 2022
Copy link
Contributor

@XieYunshen XieYunshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
单测迁移目录

Aurelius84
Aurelius84 previously approved these changes Feb 16, 2022
iclementine
iclementine previously approved these changes Feb 16, 2022
Copy link

@iclementine iclementine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Aganlengzi
Aganlengzi previously approved these changes Feb 16, 2022
Copy link
Contributor

@Aganlengzi Aganlengzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ZzSean ZzSean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for op benchmark

Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenwhql chenwhql merged commit c05cd7e into PaddlePaddle:develop Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

9 participants