Skip to content

Conversation

@Wangzheee
Copy link
Contributor

PR types

Others

PR changes

Others

Describe

支持 preln 结构的ernie模型,增加 preln_embedding_eltwise_layernorm_fuse_pass, preln_skip_layernorm_fuse_pass 两个pass

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

void operator()(PDNode *x, PDNode *y);

// declare operator node's name
PATTERN_DECL_NODE(fused_skipe_layernorm);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

后面代码中也没看到这个node,这里这个名字用不到了吧?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个之前的skip_layernorm_fuse_pass也没用到这个node,后续我提pr改下名字吧,或者删掉?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没用删掉吧

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的~

Copy link
Member

@shangzhizhou shangzhizhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wangzheee Wangzheee merged commit 2bc91cc into develop Feb 15, 2022
@luotao1 luotao1 deleted the preln_ernie branch February 22, 2022 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants