[Pten] Add selected_rows kernel for Full #39465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Thanks for your contribution! |
… fill_constant_sr
… fill_constant_sr
| #include "paddle/pten/kernels/full_kernel.h" | ||
| | ||
| #include "paddle/pten/backends/cpu/cpu_context.h" | ||
| #include "paddle/pten/backends/gpu/gpu_context.h" |
Contributor
There was a problem hiding this comment.
这里引用gpu_context.h 头文件，是否需要加 #if defined(PADDLE_WITH_CUDA) || defined(PADDLE_WITH_HIP) 宏判断？
Contributor Author
There was a problem hiding this comment.
这里可以不加宏应该也没有影响，严谨一些这里先加上宏判断，后面再看情况是否保留
| paddle::platform::float16, | ||
| paddle::platform::bfloat16, | ||
| paddle::platform::complex<float>, | ||
| paddle::platform::complex<double>) {} |
Contributor
There was a problem hiding this comment.
这里改为pten::dtype的 namespace？
| bool, | ||
| paddle::platform::float16, | ||
| paddle::platform::complex<float>, | ||
| paddle::platform::complex<double>) {} |
YuanRisheng previously approved these changes Feb 17, 2022
Comment on lines +71 to +72
| const auto& str_value = | ||
| paddle::any_cast<std::string>(ctx.Attr("str_value")); |
… fill_constant_sr
… fill_constant_sr
… fill_constant_sr
chenwhql approved these changes Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
新增Full算子SelectedRows类型的Kernel