Skip to content

add var desc proto #3933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2017
Merged

add var desc proto #3933

merged 1 commit into from
Sep 6, 2017

Conversation

@jacquesqiao
Copy link
Member

design #3835
@jacquesqiao jacquesqiao requested a review from reyoung September 6, 2017 19:10
reyoung
reyoung reviewed Sep 6, 2017
View reviewed changes
paddle/framework/framework.proto
message LoDTensorDesc {
required DataType data_type = 1;
repeated int32 dims = 2; // [UNK, 640, 480] is saved as [-1, 640, 480]
optional int32 lod_level = 3 [ default = 0 ];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lod_level is not enough for InferShape. The whole lod information should be decided while inferring shape.
reyoung
reyoung approved these changes Sep 6, 2017
View reviewed changes
Copy link
Collaborator

@reyoung reyoung left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure whether lod_level itself is enough for inferring shape, but rest of this PR looks good to me.

So I just approve it. If we find lod_level is not enough later, we would change it later.
@jacquesqiao jacquesqiao merged commit 8162e2c into PaddlePaddle:develop Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@jacquesqiao @reyoung