Op refine for making build system more automatic #3881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @typhoonzero As the commit info of #3852 is mass, I create a new PR, and all your commens are Done. |
| Seem ci failed at: |
| I see it, I am trying to fix it. |
| fix the ci error, and remove unnecessary |
reyoung reviewed Sep 5, 2017
| // identity is a alias of scale op. This is also a example for creating a alias | ||
| // operator. | ||
| template <typename AttrType> | ||
| class IdentityOpMaker : public framework::OpProtoAndCheckerMaker { |
There was a problem hiding this comment.
Why remove the identity_op?
There was a problem hiding this comment.
@reyoung 只是把 identity_op弄成了一个单独的文件，没有放在scale_op里面，并没有删掉它。这样CMakeLists.txt能自动根据operators/目录下的文件名，来获得有哪些op需要编译，之后也方便自动生成pybind.cc中的USE_OP(XXX)，而不用一个个手写添加。
typhoonzero reviewed Sep 6, 2017
| list(LENGTH cu_srcs cu_srcs_len) | ||
| list(LENGTH op_library_DEPS dep_len) | ||
| if (${cu_srcs_len} EQUAL 0 AND ${dep_len} EQUAL 0) | ||
| message(WARNING "The op library ${TARGET} not support GPU!") |
There was a problem hiding this comment.
Remove message is fine, because sometimes we can implement the CPU version only and then implement GPU version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
fix #3807 (comment)
fix #3872 : As there will be more only-CPU ops, it is not necessary to message these lines.
related #3852 .