Fix a bug when reduce_num = 1 in Reduce Op #38771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Thanks for your contribution! |
ZzSean reviewed Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
OPs
Describe
Fix a bug when reduce_num = 1 in Reduce Op, replace copy and cast kernel with elementwise kernel in reduce.h
问题场景：
当reduce_num = 1 时, 直接将输入数据给输出数据，导致 transform(x) != x 时依旧返回X。
例如transform操作为(exp(x)) 操作，当reduce_num = 1时，正确的返回结果应该为 exp(x), 但是原计算依旧返回的是 X, 从而计算错误。