[Bug fix] Fix for matmul_v2 oneDNN op broadcasting when inputs dims have different lengths #38665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Thanks for your contribution! |
Contributor
| @baoachun Please review this PR. |
Contributor
| Please see the latest comment in #38626 |
Contributor
| @Aganlengzi Could you please merge this PR. Baoachun has approved. |
Contributor
| Hi @jakpiase, could you please cherry-pick this pr to branch 2.2 ? Thanks. |
lidanqing-vv changed the title Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
OPs
Describe
Fix for matmul_v2 oneDNN op broadcasting when inputs dims have different lengths. It fixes that scenario for both FWD and BWD kernels. I have also added UTs that are covering these different input lenght broadcasting scenarios. It is a fix for #38626. I have tested "test_mkldnn_matmulv2.py" file and every test is passing after my changes