[New-Exe]Fix word2vec hang proble using InterpreterCore #38584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Thanks for your contribution! |
Aurelius84 changed the title 
zhiqiu reviewed Dec 29, 2021
Comment on lines +460 to +470
| VLOG(1) << "Exception caught " << exception_holder_.Type(); | ||
| // NOTE(xiongkun) Why we reset ? | ||
| // The caught exception may be EOFExcetion, under this situation, we need | ||
| // make async_work_queue_ available, so we need reset. | ||
| async_work_queue_->Cancel(); | ||
| async_work_queue_.reset(new interpreter::AsyncWorkQueue( | ||
| kHostNumThreads, &main_thread_blocker_)); | ||
| PADDLE_ENFORCE_EQ( | ||
| main_thread_blocker_.Clear(), 0, | ||
| platform::errors::PreconditionNotMet( | ||
| "main_thread_blocker_.Clear() return -1, clear failed")); |
Contributor
There was a problem hiding this comment.
is this ok?
if (exception_holder_.Type() != "EOF"){
async_work_queue_->Cancel();
}
exception_holder_.ReThrow();
Contributor Author
There was a problem hiding this comment.
这个问题我们讨论过，感觉不需要特判，因为用户在python端会接受到这个异常，如果用户没有退出程序，那么C++端的执行器应该保证可以再次正常运行。所以我们对所有的异常都执行了 reset 操作。
liutiexing approved these changes Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
Others