Fix the problem in fleet executor stop #38114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Thanks for your contribution! |
LiYuRio force-pushed the dev_fix_fleet_executor_stop branch from 9411ab4 to 8088ffe Compare 
FeixLiu reviewed Dec 15, 2021
Contributor
FeixLiu left a comment
FeixLiu left a comment There was a problem hiding this comment.
用GPT对一下pp=dp=mp=2的精度再合吧，以后的pr都跑一下精度再合？
LiYuRio force-pushed the dev_fix_fleet_executor_stop branch from 8088ffe to 06b5458 Compare LiYuRio force-pushed the dev_fix_fleet_executor_stop branch from 06b5458 to 1c03784 Compare FeixLiu reviewed Dec 16, 2021
| << request->src_id() << " to interceptor " << request->dst_id() | ||
| << ", with the message: " << request->message_type(); | ||
| FleetExecutor::GetCarrier().EnqueueInterceptorMessage(*request); | ||
| response->set_rst(true); |
Contributor
There was a problem hiding this comment.
突然想到，这其实可以set_rst为EnqueueInterceptorMessage的返回值，下个pr可以改一下。
Contributor
| rebase一下最新develop分支跑一下精度吧 🧐 |
chenwhql approved these changes Dec 17, 2021
Contributor
chenwhql left a comment
chenwhql left a comment There was a problem hiding this comment.
LGTM for PADDLE_ENFORCE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Describe
修复之前多卡下FleetExecutor停不下来的问题，修改对象的持有关系，将MessageBus从单例变为FleetExecutor的成员，由FleetExecutor管理它的生命周期，向Carrier传递MessageBus指针，Interceptor持有拥有者Carrier的指针，一个FleetExecutor未来会拥有多个Carrier，最终在FleetExecutor的析构函数中向Carrier上的源Interceptor发送停止的控制消息。