Skip to content

Conversation

@jim19930609
Copy link
Contributor

PR types

New features

PR changes

Others

Describe

Added fluid dependencies to Eager Dygraph #2

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for const_cast

// TODO(jiabin): Support complex forward datatype later.
}

PreparedOp::PreparedOp(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

整体copy过来,维护两份代码不太好,这个后面希望自行关注主分支的代码变化,及时同步

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

多谢,后面我做一个PR改成复用fluid里面的代码。

@JiabinYang JiabinYang merged commit 471fa1e into PaddlePaddle:develop Nov 26, 2021
Zjq9409 pushed a commit to Zjq9409/Paddle that referenced this pull request Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants