block unknown option /arch:SSE3 #37439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Thanks for your contribution! |
betterpig force-pushed the block_sse3 branch from df7741d to 151a4db Compare 
zhwesky2010 reviewed Nov 24, 2021
zhwesky2010 approved these changes Nov 25, 2021
Zjq9409 pushed a commit to Zjq9409/Paddle that referenced this pull request Dec 10, 2021
* block unknown option /arch:SSE3 * modify according to zhouwei's comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
When build in windows with_avx=off, SIMD_FLAG=${SSE3_FLAG}), this will add "/arch:SSE3" option in CMAKE_C/CC_FLAGS. However, both x86 and x64 do not surpport this option according to microsoft. As a result cl will show a warning: ignoring unknown option '/arch:SSE3' .
before
after
