[Bug fix] Add new unittests for gIOHW format in conv_transpose_mkldnn_op #37344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| ✅ This PR's description meets the template requirements! |
| Thanks for your contribution! |
ghost approved these changes Nov 30, 2021
ghost left a comment
ghost left a comment There was a problem hiding this comment.
I reran some CI's for you as they seemed to be failing for weird reasons. LGTM.
Member Author
| @jczaja please merge |
Zjq9409 pushed a commit to Zjq9409/Paddle that referenced this pull request Dec 10, 2021
…ePaddle#37344) * Add new unittests * Replace I with O channel for filter groups * Undo changes affecting other operators * Fix oneDNN namespace typo * Fix code format error
lidanqing-vv changed the title Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
OPs
Describe
test_conv2d_transpose_mkldnn_op did not cover any case with grouped filter weights. Added two cases covering it. Tests failed because there was bug related to wrong channel division.
Example:
IOHW = [4, 3, 3, 3]
gOIHW = [2, 1, 4, 3, 3] (bug)
gOIHW = [2, 3, 2, 3, 3] (expected)