[PTen]elementwise_sub kernel refactor #37260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Thanks for your contribution! |
chenwhql reviewed Nov 17, 2021
| | ||
| PD_DLL_DECL Tensor subtract(const Tensor& x, const Tensor& y) { | ||
| // 1. Get kernel signature and kernel | ||
| auto kernel_key_set = ParseKernelKeyByInputArgs(x); |
Contributor
There was a problem hiding this comment.
目前对于add和sub，这里应该是不仅根据x来确定kernel类型，可以参考原先elementwise的GetExpectedKernelType
Contributor Author
There was a problem hiding this comment.
好的，这个我记个TODO，elementwise算子迁移后改一下
| void ElementwiseSub(const CPUContext& dev_ctx, | ||
| const DenseTensor& x, | ||
| const DenseTensor& y, | ||
| int axis, |
Contributor
There was a problem hiding this comment.
这个axis参数会在原先哪些场景用到，API已经没有这个参数了，我们能否去掉？
Contributor Author
There was a problem hiding this comment.
不行，axis是用来broadcast用的
chenwhql approved these changes Nov 17, 2021
Avin0323 approved these changes Nov 18, 2021
Contributor
Avin0323 left a comment
Avin0323 left a comment There was a problem hiding this comment.
LGTM for PR-CI-OP-benchmark
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
OPs
Describe
elementwise_sub Kernel refactor