Skip to content

Conversation

@Xreki
Copy link
Contributor

@Xreki Xreki commented Nov 13, 2021

PR types

Bug fixes

PR changes

OPs

Describe

  • Paddle中可以通过设置FLAGS_cudnn_deterministic=1,强制conv cudnn算子选择算法1。但是在实现时,Forward选择算法时将deterministic参数强制设置成了false,导致FLAGS_cudnn_deterministic设置不生效。这个PR修复了这个bug。
  • 为了保持Paddle和CINN中cudnn deterministic的配置一致,在cinn_launch_op中Execute之前,增加SetCinnRuntimeFlags函数调用,当前是将CINN的cudnn_deterministic设置成与Paddle中一致。后续可能增加更多的FLAGS设置。
@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@CtfGo CtfGo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Avin0323 Avin0323 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for PR-CI-OP-benchmark

Copy link
Contributor

@wzzju wzzju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zhhsplendid zhhsplendid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xreki Xreki merged commit ea47d21 into PaddlePaddle:develop Nov 16, 2021
@Xreki Xreki deleted the fix_conv_algo branch November 16, 2021 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants