Skip to content

Conversation

@baoachun
Copy link
Contributor

@baoachun baoachun commented Nov 10, 2021

PR types

Others

PR changes

Others

Describe

移除op_teller中一些op对2维输入的过滤,该问题已经被修复了,过滤会影响业务模型推理性能。
同时更新单测。

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@baoachun baoachun changed the title remove input dim check of activation in op_teller remove input dim check in op_teller Nov 10, 2021
return false;
}
// TODO(inference): fix
if (x_shape.size() == 2 && !with_dynamic_shape) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

针对二维输入的情况是如何修复的呢?pr已经合入了吗?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

应该是这个,#36614

jiweibo
jiweibo previously approved these changes Nov 11, 2021
Copy link
Contributor

@jiweibo jiweibo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baoachun baoachun changed the title remove input dim check in op_teller remove input dim check in op_teller and update ut Nov 15, 2021
Copy link
Member

@shangzhizhou shangzhizhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shangzhizhou shangzhizhou merged commit 6b21bb0 into PaddlePaddle:develop Nov 15, 2021
@baoachun baoachun deleted the remove_activation_check branch December 31, 2021 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants