Skip to content

Conversation

@LiYuRio
Copy link
Contributor

@LiYuRio LiYuRio commented Nov 1, 2021

PR types

New features

PR changes

Others

Describe

The framework for fleet executor

@paddle-bot-old
Copy link

paddle-bot-old bot commented Nov 1, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@CLAassistant
Copy link

CLAassistant commented Nov 1, 2021

CLA assistant check
All committers have signed the CLA.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Nov 1, 2021

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@FeixLiu FeixLiu changed the title Framework for fleet executor [fleet_executor] Framework for fleet executor Nov 1, 2021
@FeixLiu FeixLiu marked this pull request as ready for review November 1, 2021 06:41
@FeixLiu FeixLiu requested a review from wangxicoding November 1, 2021 07:16
@LiYuRio LiYuRio force-pushed the executor_framework branch from def3a3c to 5c8ebe8 Compare November 2, 2021 07:14
gongweibao
gongweibao previously approved these changes Nov 2, 2021
Copy link
Contributor

@gongweibao gongweibao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有几个小的comment了,作为baseline,差不多可以merge,把其他的工作加上然后继续finetuning.

@FeixLiu FeixLiu force-pushed the executor_framework branch from a1edef9 to b2fe644 Compare November 2, 2021 08:39
@LiYuRio LiYuRio force-pushed the executor_framework branch from b2fe644 to d64028c Compare November 2, 2021 08:42
Copy link
Contributor

@FeixLiu FeixLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FeixLiu FeixLiu requested a review from wangxicoding November 2, 2021 08:52
@gongweibao gongweibao merged commit 10b039b into PaddlePaddle:develop Nov 3, 2021
ghost pushed a commit to piotrekobi/Paddle that referenced this pull request Nov 3, 2021
@LiYuRio LiYuRio deleted the executor_framework branch November 8, 2021 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants