Fix a bug in ReadData, ReadDataBc and ReadDataReduce when NX != 1 #36373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Thanks for your contribution! |
AnnaTrainingG force-pushed the primitive_init branch from 9556024 to 6f7ff7b Compare AnnaTrainingG changed the title 
zkh2016 previously approved these changes Oct 13, 2021
Liu-xiandong previously approved these changes Oct 13, 2021
AnnaTrainingG dismissed stale reviews from Liu-xiandong and zkh2016 via 081145a 
Contributor
| LGTM for modifications in attn_bias_add.cu.h. |
xingfeng01 previously approved these changes Oct 18, 2021
zkh2016 previously approved these changes Oct 18, 2021
Liu-xiandong previously approved these changes Oct 18, 2021
… primitive_init
AnnaTrainingG dismissed stale reviews from Liu-xiandong, zkh2016, and xingfeng01 via 469b364 zkh2016 approved these changes Oct 20, 2021
Liu-xiandong approved these changes Oct 20, 2021
xingfeng01 approved these changes Oct 20, 2021
Contributor
| LGTM |
Contributor
| 修复bug类的PR，描述里需要写清楚场景，最好贴上报错log、复现的case |
zhangting2020 approved these changes Oct 21, 2021
AnnaTrainingG added a commit to AnnaTrainingG/Paddle that referenced this pull request Oct 21, 2021
…ddlePaddle#36373) * Fix a bug in ReadData, ReadDataBc and ReadDataReduce when NX != 1 * Update the implement of reduceAnyKernel according to kernel primitive api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
APIs
Describe
问题描述：
在进行2D数据读取时，线程数据访问起始位置设置成 threadIdx.x * NX, 对于带stride的读取方式，正确的线程数据起始位置应该为 threadIdx.x; 原始情况会出现数据访存越界的情况，如下图所示：
出错的场景： 当使用大Kernel Primitive API 中的 2D 数据读取时， 只要将NX 设置成大于 1的数就会报错。
出错case： 当前实现并未涉及 NX > 1 的case