Skip to content

Conversation

@fuqianya
Copy link
Contributor

@fuqianya fuqianya commented Sep 24, 2021

PR types

New features

PR changes

APIs

Describe

Add DenseNet to Paddle Vision (include calling of higher-level api, test case and doc).
Doc is at PaddlePaddle/docs#3923.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@fuqianya fuqianya changed the title add DenseNet [PaddlePaddle Hackathon] add DenseNet Sep 29, 2021
@fuqianya
Copy link
Contributor Author

@LielinJiang 老师,这里也需要review,麻烦老师啦!

if self.with_pool:
y = self.pool2d_avg(conv)

if self.num_classes:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里改为>0把,意义更明确

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的,已修改

@LielinJiang
Copy link
Contributor

LielinJiang commented Oct 13, 2021

请参考这个PR:#36070
提个下自测代码和精度,并且确认可以实例化两次

@fuqianya
Copy link
Contributor Author

请参考这个PR:#36070 提个下自测代码和精度,并且确认可以实例化两次

老师,我已经自测过了,结果在 这里

@fuqianya
Copy link
Contributor Author

@LielinJiang 老师,麻烦再review一下

LielinJiang
LielinJiang previously approved these changes Oct 20, 2021
@fuqianya
Copy link
Contributor Author

@TCChenlong @XiaoguangHu01 麻烦两个老师也review一下,谢谢!

@fuqianya
Copy link
Contributor Author

@LielinJiang 老师,合并了一下冲突,重新过了一下CI,麻烦重新review一下

LielinJiang
LielinJiang previously approved these changes Oct 25, 2021
@fuqianya
Copy link
Contributor Author

谢谢~

TCChenlong
TCChenlong previously approved these changes Oct 25, 2021
@fuqianya fuqianya dismissed stale reviews from TCChenlong and LielinJiang via 5a2c4ad October 25, 2021 05:42
@fuqianya
Copy link
Contributor Author

@LielinJiang @TCChenlong 麻烦老师重新aprrove一下,又重新修改过了一下CI

@fuqianya
Copy link
Contributor Author

@LielinJiang 老师,麻烦重新approve一下

Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG API

@LielinJiang LielinJiang merged commit c09fe14 into PaddlePaddle:develop Oct 27, 2021
ghost pushed a commit to piotrekobi/Paddle that referenced this pull request Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants