Skip to content

Conversation

@baoachun
Copy link
Contributor

PR types

Bug fixes

PR changes

OPs

Describe

修改recurrent算子内部线程锁的位置,以提高该算子性能。

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@jiweibo jiweibo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

把性能数据在相应的pr中贴一下吧

@baoachun
Copy link
Contributor Author

CreateStepScopes前面加锁
图片

CreateStepScopes内部加锁
图片

去掉锁
图片

可以看到将锁移到CreateStepScopes内部能大幅提升网络性能,不过还需要确认能否直接去掉锁。

@Superjomn Superjomn merged commit 372a1a7 into PaddlePaddle:develop Sep 25, 2021
AnnaTrainingG pushed a commit to AnnaTrainingG/Paddle that referenced this pull request Sep 29, 2021
@baoachun baoachun deleted the fix_recurrent branch December 31, 2021 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants