Skip to content

Conversation

@jacquesqiao
Copy link
Member

fix #3603

@jacquesqiao jacquesqiao requested a review from dzhwinter August 21, 2017 17:19
@jacquesqiao jacquesqiao self-assigned this Aug 21, 2017
Copy link
Contributor

@dzhwinter dzhwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++.
need to confirm the comment things first. :)

// https://eigen.tuxfamily.org/dox/unsupported/TensorBase_8h_source.html
// colwise add
Eigen::array<int, 1> dims{{1}}; /* dimension to reduce */
Eigen::array<int, 1> dims{{0}}; /* dimension to reduce */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to confirm that will do a col-wise sum.

@jacquesqiao jacquesqiao merged commit 0d1715d into PaddlePaddle:develop Aug 21, 2017
@jacquesqiao jacquesqiao mentioned this pull request Aug 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants