refine random related operators #3596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
dzhwinter reviewed Aug 22, 2017
There was a problem hiding this comment.
so, we decide to implement all the random methods in thrust?
Not a good news, we need to implement more generator in thrust by ourselves such as random_gama, ramdom_guassian
tf.random_normal
tf.truncated_normal
tf.random_uniform
tf.random_shuffle
tf.random_crop
tf.multinomial
tf.random_gamma
| // And we need a global random seed configuration. | ||
| int seed = context.op_.GetAttr<int>("seed"); | ||
| unsigned int seed = | ||
| static_cast<unsigned int>(context.op_.GetAttr<int>("seed")); |
There was a problem hiding this comment.
it is useless to convert int to unsigned int. Attribute Member can not contain an unsigned int.
There was a problem hiding this comment.
And maybe we can add unsigned to attribute map
dzhwinter approved these changes Aug 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix #3598