Add op paddle.device.cuda.get_device_name and paddle.device.cuda.get_device_capability. #35672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Thanks for your contribution! |
… get_device_name
… get_device_name
… get_device_name
… get_device_name
… get_device_name
… get_device_name
sneaxiy reviewed Sep 15, 2021
paddle/fluid/platform/gpu_info.cc Outdated
| PADDLE_ENFORCE_GT(id, -1, platform::errors::InvalidArgument( | ||
| "Device id must be greater than -1, " | ||
| "but received id is: %d. ", | ||
| id)); |
Collaborator
There was a problem hiding this comment.
I wonder whether hipGetDeviceProperties and cudaGetDeviceProperties can accept the case id = -1. In my experience, they cannot. So I prefer GetCUDADeviceName should not accept the case id = -1. Users should deal with the case id = -1 outside this function.
Collaborator
There was a problem hiding this comment.
Sorry for my wrong understanding. PADDLE_ENFORCE_GT(id, -1) is right here. But I prefer PADDLE_ENFORCE_GE(id, 0) instead. The latter would be more clear.
… get_device_name
… get_device_name
sneaxiy reviewed Sep 27, 2021
… get_device_name
… get_device_name
… get_device_name
sneaxiy reviewed Sep 28, 2021
| # required: gpu | ||
| import paddle | ||
liyagit21 changed the title sneaxiy previously approved these changes Sep 28, 2021
… get_device_name
TCChenlong approved these changes Sep 28, 2021
lanxianghit approved these changes Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
OPs
Describe
Add op paddle.device.cuda.get_device_name and paddle.device.cuda.get_device_capability.
