FIX: Release CPU/GPU memory at the end of the Program #3534
+49 −20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
gangliao commented Aug 17, 2017
| | ||
| for (int i = 0; i < 4; ++i) EXPECT_EQ(p_output[i], i + 4); | ||
| for (int i = 4; i < 8; ++i) EXPECT_EQ(p_output[i], i - 4); | ||
| |
There was a problem hiding this comment.
@zchen0211 return tensor memory back to buddy allocator for free.
gangliao changed the title 
QiJune reviewed Aug 17, 2017
paddle/memory/memory.cc Outdated
| | ||
| BuddyAllocator* GetCPUBuddyAllocator() { | ||
| static std::unique_ptr<BuddyAllocator, void (*)(BuddyAllocator*)> a{ | ||
| nullptr, [](BuddyAllocator* p) { delete p; }}; |
There was a problem hiding this comment.
Why here need to pass a lambda function, unique_ptr will delete the pointer automaticlly
There was a problem hiding this comment.
You are right! Deleter could be default one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
After unit test is passed, release memory!
fix #3536
fix #3537