Add a check for multiplex op #34972
Merged
Add a check for multiplex op #34972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ForFishes reviewed Sep 22, 2021
| auto* out = ctx.Output<Tensor>("Out"); | ||
| out->mutable_data<T>(ctx.GetPlace()); | ||
| | ||
| PADDLE_ENFORCE_GT(ins[0]->numel(), 0, |
Member
There was a problem hiding this comment.
Why only check the first tensor of the input? Shouldn't it be checked more than one becasue of MultiInput type?
| | ||
| out->mutable_data<T>(ctx.GetPlace()); | ||
| | ||
| PADDLE_ENFORCE_GT(ins[0]->numel(), 0, |
| | ||
| PADDLE_ENFORCE_GT(ins[0]->numel(), 0, | ||
| platform::errors::PreconditionNotMet( | ||
| "indexing will be out of bounds with size 0.")); |
Member
There was a problem hiding this comment.
indexing->index ? PreconditionNotMet-> OutOfRange?
AnnaTrainingG pushed a commit to AnnaTrainingG/Paddle that referenced this pull request Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Ops
Describe
The paddle.multiplex will break down when the size of candidate tensors is zero and doesn't give useful an error message. This pr will check the situation and gives user more information.