Use ostream << operator to get to_string #3349
Merged
+123 −4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
* Make `PADDLE_ENFORCE_EQ` supports custom class, like DDim
qingqing01 reviewed Aug 9, 2017
paddle/string/to_string_test.cc Outdated
| | ||
| // std::to_string might fill zero after float value, like 1.2000 | ||
| for (size_t i = 0; i < my_to_string.size(); ++i) { | ||
| ASSERT_EQ(my_to_string[i], std_to_string[i]); |
There was a problem hiding this comment.
可以去掉std::to_string，直接改成"10", "1.2"来比较吗？ 而不是加#if !defined(ANDROID) && !defined(__ANDROID__) 来避免
qingqing01 approved these changes Aug 9, 2017
paddle/string/to_string_test.cc Outdated
| #include "paddle/string/to_string.h" | ||
| #include <gtest/gtest.h> | ||
| | ||
| constexpr char OUT_STR[] = "User Defined Output"; |
There was a problem hiding this comment.
https://google.github.io/styleguide/cppguide.html#Constant_Names
Variables declared constexpr or const, and whose value is fixed for the duration of the program, are named with a leading "k" followed by mixed case. For example:
const int kDaysInAWeek = 7; Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PADDLE_ENFORCE_EQsupports custom class, like DDim