Make C lib in paddle.v2.master.client lazy load #3045
Merged
+17 −9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Currently, WITH_GOLANG is a compiling flag, and not all Paddle binary enable `WITH_GOLANG=ON`. So we cannot ensure that every paddle has `master.so`. Make load that C libary lazily could let the user run Paddle without `WITH_GOLANG=ON`.
typhoonzero approved these changes Jul 25, 2017
python/paddle/v2/master/client.py Outdated
| | ||
| def get_c_lib(): | ||
| if __lib__ is None: | ||
| global __lib__ |
There was a problem hiding this comment.
Put global right under the function define.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Currently, WITH_GOLANG is a compiling flag, and not all Paddle binary
enable
WITH_GOLANG=ON. So we cannot ensure that every paddle hasmaster.so. Make load that C libary lazily could let the user runPaddle without
WITH_GOLANG=ON.Fix #3052