update gradient operator registry mechanism #3036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
OLD: op_type -> grad_op_creator NEW: grad_op_type -> grad_op_creator op_type -> grad_op_type
dzhwinter reviewed Jul 25, 2017
| return op_creators_; | ||
| } | ||
| | ||
| private: |
There was a problem hiding this comment.
why make op_creators public? In my mind, it is only used by the CreatorOp and RegisterOp.
There was a problem hiding this comment.
It's also used by GradOpBuilder. Because all gradient operators are also registered in op_creators.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
OLD:
op_type --> grad_op_creator
NEW:
grad_op_type --> grad_op_creator
op_type --> grad_op_type
This change makes it possible to register grad op's grad op.