Skip to content

Optimize ptr #2851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 14, 2017
Merged

Optimize ptr #2851

merged 6 commits into from
Jul 14, 2017

Conversation

@jacquesqiao
Copy link
Member

@jacquesqiao jacquesqiao commented Jul 13, 2017 •
edited
Loading

  • CreateOp should return std::shared_ptr for python API
  • Use ScopePtr to shorten std::shared_ptr
@jacquesqiao jacquesqiao mentioned this pull request Jul 13, 2017
Merged
@jacquesqiao jacquesqiao requested a review from reyoung July 14, 2017 01:57
reyoung
reyoung approved these changes Jul 14, 2017
View reviewed changes
Copy link
Collaborator

@reyoung reyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe OperatorPtr is a better name
paddle/framework/net.h Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const ScopePtr&
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done
paddle/framework/op_registry_test.cc Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

??
GTEST has a ASSERT_THROW macro.

Maybe in following PRs that part could be changed.
paddle/framework/operator.h Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe OperatorPtr is a better name for consistency.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done
@jacquesqiao jacquesqiao merged commit 58f3de9 into PaddlePaddle:develop Jul 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@jacquesqiao @reyoung