Init partial network parameters from another saved model. #2664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
qingqing01 commented Jun 29, 2017
| (shape, value.shape)) | ||
| | ||
| if len(self.__gradient_machines__) == 0: | ||
| self.__tmp_params__.append((key, value)) |
There was a problem hiding this comment.
The append could lead the repeated key in self.__tmp_params__. This is a bug.
reyoung approved these changes Jun 29, 2017
| params.deserialize(param_name, f) | ||
| return params | ||
| | ||
| def init_from_tar(self, f): |
There was a problem hiding this comment.
Because from_tar is a static method. Maybe Parameters.from_tar is better.
NHZlX approved these changes Jun 29, 2017
pkuyym reviewed Jun 29, 2017
| @pkuyym add comments. |
| The usage example should be : |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix #2663
The usage example is: