Adding Enforce to platform #2646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
reyoung force-pushed the feature/add_enforce branch from dcc7d0c to 09dcc7a Compare 
Basically from caffe2::logging.h, but only expose `PADDLE_ENFORCE` interface.
reyoung force-pushed the feature/add_enforce branch from 09dcc7a to 3a119ef Compare 
jacquesqiao reviewed Jun 28, 2017
paddle/platform/enforce.h Outdated
| @@ -0,0 +1,116 @@ | |||
| /* | |||
There was a problem hiding this comment.
The Copyright format is not right, please use this
jacquesqiao reviewed Jun 28, 2017
paddle/platform/enforce_test.cc Outdated
| @@ -0,0 +1,25 @@ | |||
| #include <gtest/gtest.h> | |||
jacquesqiao reviewed Jun 28, 2017
paddle/platform/enforce.h Outdated
| all_msg_ = sout.str(); | ||
| } | ||
| | ||
| const char* what() const noexcept override { return all_msg_.c_str(); } |
There was a problem hiding this comment.
why not just return a std::string
There was a problem hiding this comment.
because it is the std::exception interface.
This was referenced Jun 28, 2017
wangkuiyi approved these changes Jun 28, 2017
paddle/platform/enforce.h Outdated
| | ||
| namespace details { | ||
| | ||
| inline void MakeStringInternal(std::ostringstream& stream) {} |
There was a problem hiding this comment.
We should replace MakeString by string::Printf in the near future. I have a PR working on string::Printf.
There was a problem hiding this comment.
Done, and wait for CI. After passing CI tests, this PR will be merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Basically from caffe2::logging.h, but only expose
PADDLE_ENFORCEinterface.