Skip to content

Conversation

@LielinJiang
Copy link
Contributor

@LielinJiang LielinJiang commented Aug 19, 2020

PR types

New features

PR changes

APIs

Describe

Update conv_transpose2d, conv_transpose3d, ConvTranspose2d, ConvTranspose3d api

TODO:

  1. 支持output_size为tensor的输入(静态图)。
  2. 经过粗略的测试与竞品参考(tf),目前use_cudnn在使用depthwise默认会设置为false,并且使用depthwise_conv_transpose op。后续可能任然需要更多的测试。部分测试数据如下:
    image
    image
    image
@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@willthefrog willthefrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for future reference, maybe add the reasoning and bench result of use_cudnn setting to PR description

also, the code does not seem to be DRY enough, consider:

  • extract conv_nd function
  • reference to class description in functional docstring
Copy link
Contributor

@willthefrog willthefrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need subsequent PR to add tensor input for output_size, otherwise LGTM

@LielinJiang LielinJiang merged commit d26ae9a into PaddlePaddle:develop Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants