Skip to content

Conversation

@helinwang
Copy link
Contributor

No description provided.

@Yancey0623
Copy link
Contributor

I checked out this PR, but it also failed with go test ./..., maybe I missed something?

$ go test ./... ?	github.com/PaddlePaddle/Paddle/go/cmd/master	[no test files] ?	github.com/PaddlePaddle/Paddle/go/cmd/pserver	[no test files] ?	github.com/PaddlePaddle/Paddle/go/connection	[no test files] ok	github.com/PaddlePaddle/Paddle/go/master	0.991s ?	github.com/PaddlePaddle/Paddle/go/master/c	[no test files] signal: killed FAIL	github.com/PaddlePaddle/Paddle/go/pserver	0.008s ?	github.com/PaddlePaddle/Paddle/go/pserver/cclient	[no test files] ok	github.com/PaddlePaddle/Paddle/go/utils/networkhelper	0.019s
Copy link
Contributor

@dzhwinter dzhwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dzhwinter
Copy link
Contributor

dzhwinter commented Jun 28, 2017

confirmed.

@typhoonzero
Copy link
Contributor

typhoonzero commented Jun 28, 2017

@Yancey1989 you need to upgrade go to > 1.8.1, this was a go bug.


Thanks @typhoonzero , go test ./... can pass all the test. --Yancey1989

Copy link
Contributor

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Yancey0623 Yancey0623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@helinwang helinwang merged commit 2f52cb7 into PaddlePaddle:develop Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants