fix paddle.nn.loss.L1Loss OP, add paddle.nn.functional.l1_loss OP for API2.0, test=develop #26040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Thanks for your contribution! |
| ✅ This PR's description meets the template requirements! |
wawltor reviewed Aug 7, 2020
python/paddle/nn/functional/loss.py Outdated
python/paddle/nn/functional/loss.py Outdated
There was a problem hiding this comment.
建议在2.0中将paddel.reduce_sum 改成paddel.sum paddle.reduce_mean改成paddle.mean
python/paddle/nn/functional/loss.py Outdated
python/paddle/nn/functional/loss.py Outdated
LutaoChu force-pushed the l1loss-op branch 5 times, most recently from 2c8fc55 to 23214ac Compare 
LutaoChu force-pushed the l1loss-op branch 3 times, most recently from b873ff7 to c81047e Compare 
ZHUI reviewed Aug 11, 2020
python/paddle/nn/layer/loss.py Outdated
ZHUI reviewed Aug 11, 2020
python/paddle/nn/layer/loss.py Outdated
… API2.0, test=develop
TCChenlong reviewed Aug 12, 2020
| reduction (str, optional): Indicate the reduction to apply to the loss, | ||
| the candicates are ``'none'`` | ``'mean'`` | ``'sum'``. | ||
| If :attr:`reduction` is ``'none'``, the unreduced loss is returned; | ||
| If :attr:`reduction` is ``'mean'``, the reduced mean loss is returned. |
There was a problem hiding this comment.
【If :attr:reduction is 'mean'】->【If reduction is 'mean'】
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
APIs
Describe
fix paddle.nn.loss.L1Loss OP, add paddle.nn.functional.l1_loss OP for API2.0