Skip to content

Ones op for API 2.0: remove the device and out parameters #25497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Jul 20, 2020
Merged

Ones op for API 2.0: remove the device and out parameters #25497

merged 20 commits into from
Jul 20, 2020
+116 −88

Conversation

@wangchaochaohu
Copy link
Contributor

@wangchaochaohu wangchaochaohu commented Jul 13, 2020 •
edited
Loading

PR types

Function optimization

PR changes

APIs

Describe

new API

ones(shape, dtype=None, name=None)

image
@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.
zhupengyang
zhupengyang reviewed Jul 14, 2020
View reviewed changes
zhupengyang
zhupengyang reviewed Jul 15, 2020
View reviewed changes
zhupengyang
zhupengyang previously approved these changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@zhupengyang zhupengyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
wawltor
wawltor reviewed Jul 15, 2020
View reviewed changes
wawltor
wawltor previously approved these changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
zhupengyang
zhupengyang previously approved these changes Jul 15, 2020
View reviewed changes
@wangchaochaohu wangchaochaohu dismissed stale reviews from zhupengyang and wawltor via 712ed06 July 17, 2020 02:48
zhupengyang
zhupengyang previously approved these changes Jul 17, 2020
View reviewed changes
Copy link
Contributor

@zhupengyang zhupengyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
zhupengyang
zhupengyang previously approved these changes Jul 17, 2020
View reviewed changes
swtkiwi
swtkiwi previously approved these changes Jul 17, 2020
View reviewed changes
Copy link
Contributor

@swtkiwi swtkiwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
lanxianghit
lanxianghit reviewed Jul 19, 2020
View reviewed changes
@wangchaochaohu wangchaochaohu dismissed stale reviews from swtkiwi and zhupengyang via 605038f July 19, 2020 05:57
lanxianghit
lanxianghit approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@lanxianghit lanxianghit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
swtkiwi
swtkiwi approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@swtkiwi swtkiwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@wangchaochaohu wangchaochaohu merged commit 2092660 into PaddlePaddle:develop Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants

@wangchaochaohu @wawltor @swtkiwi @lanxianghit @zhupengyang